0.45.0: Build failure due to missing dsp.h

[dvzrv]

Hi! :wave:

When building 0.45.0 from source I ran into an issue with a header file that can not be found:

[ 914/1082] Compiling src/LV2/faust-generated/tremolo.cc
15:47:58 runner ' cp ../src/LV2/faust-generated/tremolo.cc src/LV2/faust/tremolo.cc '
In file included from ../src/headers/engine.h:120,
                 from ../src/ladspa/ladspa_guitarix.cpp:32:
../src/headers/gx_internal_plugins.h:25:10: fatal error: dsp.h: No such file or directory
   25 | #include "dsp.h"
      |          ^~~~~~~
compilation terminated.

Waf: Leaving directory `/build/guitarix/src/build'
  File "/usr/bin/waf", line 168, in <module>
    Scripting.waf_entry_point(cwd, VERSION, wafdir)
  File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 159, in waf_entry_point
    run_commands()
  File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 255, in run_commands
    ctx = run_command(cmd_name)
  File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 239, in run_command
    ctx.execute()
  File "/lib/python3.11/site-packages/waf/waflib/Scripting.py", line 588, in execute
    return execute_method(self)
  File "/lib/python3.11/site-packages/waf/waflib/Build.py", line 231, in execute
    self.execute_build()
  File "/lib/python3.11/site-packages/waf/waflib/Build.py", line 251, in execute_build
    self.compile()
  File "/lib/python3.11/site-packages/waf/waflib/Tools/errcheck.py", line 192, in check_compile
    ret = self.orig_compile()
  File "/lib/python3.11/site-packages/waf/waflib/Build.py", line 355, in compile
    raise Errors.BuildError(self.producer.error)
  File "/lib/python3.11/site-packages/waf/waflib/Errors.py", line 46, in __init__
    WafError.__init__(self, self.format_error())

Build failed
 -> task in 'ladspa_guitarix' failed with exit status 1:
        {task 126792587639424: cxx ladspa_guitarix.cpp -> ladspa_guitarix.cpp.1.o}
['/usr/bin/g++', '-march=x86-64', '-mtune=generic', '-O2', '-pipe', '-fno-plt', '-fexceptions', '-Wp,-D_FORTIFY_SOURCE=2', '-Wformat', '-Werror=format-security', '-fstack-clash-protection', '-fcf-protection', '-Wp,-D_GLIBCXX_ASSERTIONS', '-g', '-ffile-prefix-map=/build/guitarix/src=/usr/src/debug/guitarix', '-flto=aut
o', '-flto', '-O3', '-DNDEBUG', '-ffat-lto-objects', '-std=c++17', '-DDSP_SAMPLE_FLOAT', '-DNAM_SAMPLE_FLOAT', '-Dneural_amp_modeler_EXPORTS', '-fvisibility=hidden', '-fPIC', '-pthread', '-pthread', '-pthread', '-pthread', '-pthread', '-pthread', '-Isrc/headers', '-I../src/headers', '-Isrc', '-I../src', '-Ilibgxwmm',
'-I../libgxwmm', '-Ilibgxw', '-I../libgxw', '-I/usr/include/opus', '-I/usr/include/glib-2.0', '-I/usr/lib/glib-2.0/include', '-I/usr/include/sysprof-6', '-I/usr/include/glibmm-2.4', '-I/usr/lib/glibmm-2.4/include', '-I/usr/include/sigc++-2.0', '-I/usr/lib/sigc++-2.0/include', '-I/usr/include/giomm-2.4', '-I/usr/lib/gi
omm-2.4/include', '-I/usr/include/libmount', '-I/usr/include/blkid', '-I/opt/local/include', '-I/usr/include/lilv-0', '-I/usr/include/sord-0', '-I/usr/include/serd-0', '-I/usr/include/sratom-0', '-I/usr/include/zix-0', '-I/usr/include/eigen3', '-DIS_LINUX="linux"', '-DLOCALEDIR="/usr/share/locale"', '-DGETTEXT_PACKAGE
="guitarix"', '-DENABLE_NLS=1', '-DHAVE_SNDFILE=1', '-DHAVE_FFTW3_H=1', '-DHAVE_FFTW3=1', '-DHAVE_JACK=1', '-DHAVE_GMODULE_EXPORT=1', '-DHAVE_CURL=1', '-DHAVE_GTHREAD=1', '-DHAVE_GLIBMM=1', '-DHAVE_GTK2=1', '-DHAVE_GTKMM=1', '-DHAVE_GIOMM=1', '-DHAVE_LADSPA_H=1', '-DHAVE_LRDF=1', '-DHAVE_LILV=1', '-DZITA_CONVOLVER=1',
 '-DZITA_CONVOLVER_VERSION=4', '-DZITA_RESAMPLER=1', '-DGX_STYLE_DIR="/usr/share/gx_head/skins"', '-DGX_FACTORY_DIR="/usr/share/gx_head/factorysettings"', '-DGX_SOUND_DIR="/usr/share/gx_head/sounds"', '-DGX_SOUND_BPB_DIR="/usr/share/gx_head/sounds/bands"', '-DGX_SOUND_BPA_DIR="/usr/share/gx_head/sounds/amps"', '-DGX_B
UILDER_DIR="/usr/share/gx_head/builder"', '-DGX_ICON_DIR="/usr/share/guitarix/icons"', '-DGX_PIXMAPS_DIR="/usr/share/pixmaps"', '-DGX_METAINFO_DIR="/usr/share/metainfo"', '-DGX_VERSION="0.45.0"', '-DOS_64_BIT=1', '-DHAVE_SIGC=1', '-DHAVE_LV2CORE=1', '-DGX_LV2_STYLE_DIR="/usr/share/gx_head/skins/LV2"', '-DHAVE_AVAHI_GO
BJECT=1', '-DHAVE_AVAHI_GLIB=1', '-DHAVE_AVAHI_CLIENT=1', '-DHAVE_AVAHI=1', '-DHAVE_BLUEZ=1', '-DHAVE_LIBLO=1', '-DHAVE_EIGEN3=1', '-DHAVE_CAIRO=1', '-DHAVE_X11_XLIB_H=1', '-DLADSPA_SO', '../src/ladspa/ladspa_guitarix.cpp', '-c', '-o/build/guitarix/src/build/src/ladspa/ladspa_guitarix.cpp.1.o']

My assumption is, that this is supposed to find /usr/include/faust/dsp/dsp.h but somehow doesn't.

[brummer10]

Do you still build the old ladspa plug? Please, don't do that. We've now the vst3 plug here https://github.com/brummer10/guitarix.vst which serves much better then this old dinosaur.

I must admit that I haven't checkout if the old ladspa build, and as it seems it doesn't.
Time to remove it.

[brummer10]

I forgot to mention, this "dsp.h" file is part of the Neural Amp Modeler which I indeed haven't include into this old ladspa plug, while it use the same source as the main app, it fail to build. However, as I said, please remove the ladspa plug as with the next release I'll remove it completely from the source.

[dvzrv]

We've now the vst3 plug here https://github.com/brummer10/guitarix.vst which serves much better then this old dinosaur.

Ah, good to know! Will do! (and yes time to drop ladspa...)

[dvzrv]

Removing the --ladspa and --new-ladspa waf options resolves this issue.