brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
287 stars 34 forks source link

build system: LTO detection fails if -flto=auto or similar is used #149

Closed Tatsh closed 8 months ago

Tatsh commented 8 months ago

Your LTO detection doesn't account for when -flto=auto, -flto=N, etc are used. The arguments are beneficial to tweak LTO processing.

https://github.com/brummer10/guitarix/blob/master/trunk/waftools/cpu_optimization.py#L171-L173

Instead of this check you could use if any(x.startswith('-flto') for x in cxxflags):.

https://bugs.gentoo.org/926429

brummer10 commented 8 months ago

Thanks for the pointer. I've pushed the fix to the repository.

Tatsh commented 8 months ago

Thanks!