Unable to compile 0.46.0

[dvzrv]

Hi! :wave:

I'm currently trying to upgrade the Arch Linux package but am unable to do so:

Setting top to                           : /build/guitarix/src/guitarix-0.46.0
Setting out to                           : /build/guitarix/src/guitarix-0.46.0/build
Checking for git submodule               : not checked
Checking for program 'msgfmt'            : /usr/bin/msgfmt
Checking for program 'perl'              : /usr/bin/perl
Checking for program 'intltool-merge'    : /usr/bin/intltool-merge
Checking for 'g++' (C++ compiler)        : /usr/bin/g++
Checking for program 'pkg-config'        : /usr/bin/pkg-config
Checking for 'sndfile'                   : yes
Checking for header fftw3.h              : yes
Checking for 'fftw3f'                    : yes
Checking for 'jackd1'                    : not found
Checking for 'jackd2'                    : yes
Checking for 'gmodule-export-2.0'        : yes
Checking for 'libcurl'                   : yes
Checking for font RobotoCondensed        : ok
Checking for program 'sassc'             : /usr/bin/sassc
Checking for 'gthread-2.0'               : yes
Checking for 'glibmm-2.4'                : yes
Checking for 'gtk+-3.0'                  : yes
Checking for 'gtkmm-3.0'                 : yes
Checking for 'giomm-2.4'                 : yes
Checking for header ladspa.h             : ladspa.h not found, using included version now
Checking for 'lrdf'                      : yes
Checking for 'lilv-0'                    : yes
Checking for boost-system                : yes
Checking for boost >= 1.42               : yes
Checking for boost_iostreams >= 1.42     : yes
Checking for zita-convolver >= 3.0       : Zita-convolver version 3 not found, trying version 4
Checking for zita-convolver >= 4.0       : yes
Checking for zita-resampler >= 1.0       : yes
Checking for program 'gperf'             : /usr/bin/gperf
Checking for program 'faust'             : /usr/bin/faust
Checking for faust version               : can't use 2.70.3 (check ./waf --help)
Checking for program 'strip'             : /usr/bin/strip
Checking for 'sigc++-2.0'                : yes
Checking for 'lv2'                       : yes
Checking for 'avahi-gobject'             : yes
Checking for 'avahi-glib'                : yes
Checking for 'avahi-client'              : yes
Checking for 'bluez'                     : yes
Checking for 'liblo'                     : yes
Checking for 'eigen3'                    : yes
Checking for program 'ld'                : /usr/bin/ld
Checking for 'cairo'                     : yes
Checking for library X11                 : not found
The configuration failed
(complete log in /build/guitarix/src/guitarix-0.46.0/build/config.log)

Build script: https://gitlab.archlinux.org/archlinux/packaging/packages/guitarix/-/blob/9c693d61868b88c8847701f642b3093ddaa0e5b4/PKGBUILD

Log: config.log

FTR: libx11 is definitely available in the build environment and 0.45.0 was able to find it just fine.

I'm building with a distribution provided waf (2.0.27) as the bundled version is always outdated and does not support current/newer Python. I am not sure whether this is a configuration issue or a waf issue (but on my side nothing has changed since last version (0.45.0), apart from waf 2.0.26 -> 2.0.27)

[brummer10]

Hi I have nothing changed on this Check, it's Here https://github.com/brummer10/guitarix/blob/master/trunk/src/LV2/xputty/wscript#L19

So I suspect that the system waf handle that now different.

[hfiguiere]

I'm building with a distribution provided waf (2.0.27) as the bundled version is always outdated and does not support current/newer Python.

The provided version works fine with Python 3.11. There was an incompatibility that was fixed in 0.45

[brummer10]

I've done a quick test with waf-2.0.27 and it shows that the check for X11 must be changed to make it work, this is the diff

--- a/trunk/src/LV2/xputty/wscript
+++ b/trunk/src/LV2/xputty/wscript
@@ -16,8 +16,8 @@ def configure(conf):
         # workaround: "-liconv" required at end of linker cmdline
         conf.env.append_value('STLIB_CAIRO', ['iconv'])
     else:
-        conf.check_cc(lib='X11', uselib_store='X11', mandatory=True) and \
-        conf.check_cc(header_name = 'X11/Xlib.h', uselib_store = 'X11', mandat$
+        conf.check(lib='X11', uselib_store='X11', mandatory=True) and \
+        conf.check(header_name = 'X11/Xlib.h', uselib_store = 'X11', mandatory$

 def build(bld):
     if not (bld.env.LV2GUI):

[brummer10]

. . and as it works this way as well with the current included waf version I pushed the fix to the repository now.

[dvzrv]

@brummer10 many thanks for getting back on this so quickly!

The mentioned patch indeed solves the issue for me! :tada: