search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
249 stars 26 forks source link

French translation update to 100% #41

Closed trebmuh closed 3 years ago

brummer10 commented 3 years ago

The mnemonic key's looks wrong for the menu entry's. They should match the one in the original string, or don't be there at all. Still I'll merge this PR, but you may like to correct that before we release.

regards hermann

trebmuh commented 3 years ago

I assume you're talking about the "_" signs (such as "_Q" for Quit).

I don't understand why you say:

They should match the one in the original string, or don't be there at all.

In all the translations I've seen so far, when a letter used for a mnemonic in the English string isn't present in its translation strings, then we're left with a choice:

  1. keep the same mnemonic in parenthesis, such as: "_Quit" -> "Sortir (_Q)"
  2. use another letter, such as "_Quit" -> "_Sortir"

The second choice is better for the user since it's more natural. But we have to take care about not clashing with another already used mnemonic. Which I've only did partially so far.

I'll have a precise look at the mnemonics today.

brummer10 commented 3 years ago

That' what I mean, I see of lot of duplicated mnemonics in the translation.

trebmuh commented 3 years ago

I found 9 of these, see the #42 PR. Did you see any other?