search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
249 stars 26 forks source link

version 0.42.0 - About dialog box has wrong version number #43

Closed Rippert closed 3 years ago

Rippert commented 3 years ago

Just tried version 0.42.0. Overall very good, but did notice that the dialog box that opens when the Aboutmenus is clicked lists the version number as 0.41.0. I did check the git log, and I am using 0.42.0.

hfiguiere commented 3 years ago

FWIW: I just built it (from the tarball) and it show the right version.

Rippert commented 3 years ago

Ok. I just did an incremental build. I'll try a full rebuild when I get a chance.

On Sun, Dec 20, 2020, 2:21 PM Hubert Figuière notifications@github.com wrote:

FWIW: I just built it (from the tarball) and it show the right version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brummer10/guitarix/issues/43#issuecomment-748672451, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRNJYRVBYSIJXUFCDXBIGLSVZTENANCNFSM4VDKQYAQ .

brummer10 commented 3 years ago

The version is set in the wscript, so, yes, to get the version right you must at least run ./waf configure so that the new version is written to config.h

Rippert commented 3 years ago

OK. A new ./waf configure fixed it.