brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
279 stars 34 forks source link

Fuzz Face Mayer broken in git #50

Closed Gimmeapill closed 3 years ago

Gimmeapill commented 3 years ago

Hi Hermann,

I have just noticed an issue with the FF Mayer on Arch Linux (latest git): it sounds like there's a badly set up noise gate with a slow volume ramp up and is pretty much unusable (tested both at 96 &48 Khz). Last I remember it was working fine as of December, so this could be due to one of the latest commits like maybe: https://github.com/brummer10/guitarix/commit/634748f220027a99782f9fa80aa30e0cb7ea5ef7

Arch is changing quite fast, so I wouldn't be able to pinpoint what library was upgraded during that time. I have currently: faust 2.30.5-1 boost1.75.0-2

I also didn't notice any issue with the other plugins (so far)

BR,

LX

brummer10 commented 3 years ago

Hi Yea, it may be that we've broken FF Mayer by our latest changes, I'll investigate. Thanks for reporting the issue. regards hermann

brummer10 commented 3 years ago

Hi I've pushed a Fix for it now to the repository. regards hermann

Gimmeapill commented 3 years ago

The weird noise gate artifact is gone, but the fuzz doesn't quite sound like it used to: it cannot handle the buffer booster I have in most of my presets and goes straight into clipping/feedback. It is also extremely noisy. Removing the booster and most of the gain is gone but the noise is still there. All tests done at 96KHz

brummer10 commented 3 years ago

So here is a new attempt to fix Fuzz Face Mayer.

Gimmeapill commented 3 years ago

A bit better, but it still sounds like it is clipping internally with both controls at 1.00 and a booster in front. The amount of noise also still seems to be excessive (compared to what it used to be). In comparison, the original Fuzz Face doesn't seem to have the issue, neither does the FF Fuller or the Bass Fuzz. A/B switching between the Fuzz Face and the FF Mayer and there is a relatively high volume jump, when I would have expected just a bit more gain (at least this is what I remember from when I was testing them a few years ago - I cannot really advise about the HW versions). So I still don't think that one is really working the way it was at very high gain settings. Btw, I also gave it a run at 48Khz and the behavior is the same.

brummer10 commented 3 years ago

So I tried one more time, roll back the version from 20 May 2016, just with a bit reduced gain and make the Level control logarithmic.

Gimmeapill commented 3 years ago

A tiny a bit better, but I'm afraid it is still clipping with everything at max and sounds more messy than what I remember it to be (I'm fairly sure it used to sound like butter no matter how hard I abused the input volume - which is why I had selected it over the other emulations in the first place). But by lack of ability to test older guitarix builds, the only example I can give is the volume difference when switching between the Fuzz Face and the FF Mayer with both controls at 1, they shouldn't be too different apart from a bit more gain and headroom, yet there's a quite significant volume spike... Unfortunately the originals are quite hard to come by (assuming they still even exist in working condition), so I'm reduced to guesswork here. So if you think it's behaving like it should, let's close the issue, this is not such a bit deal for me.

brummer10 commented 3 years ago

I'm so stupid. Looking all the time in the wrong place. It was the new generated table which leads to this unwanted beehive. I'm pretty sure we are back with the original sound now. Sorry that it takes me so long. regards hermann

Gimmeapill commented 3 years ago

That was it! I can confirm that the FF Mayer is back to its former glory - thanks ;-) But...aren't the the other fuzzes affected as well? It's the original FF that sounds out of place now...

brummer10 commented 3 years ago

Nope, the original FuzzFace use a other approve which isn't infected by this issue. (And still it sounds to me like ever).

Gimmeapill commented 3 years ago

Never mind then it's all good - thanks again for fixing