search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
249 stars 26 forks source link

Low latency #61

Closed Rippert closed 3 years ago

Rippert commented 3 years ago

fixes #56

Here's the new command line option -W --no-watchdog-warning. Tested on my RPi, and it works. Only tested the effect on the convolver watchdog as I cannot get any of the other bypassed watchdogs to ever throw a warning. So: No overload options - engine bypass due to convolver and notice pop-up appears. -C option - no engine bypass, warning of bypassed watchdog appears. -C and -W options - no pop-up, just some xruns. -W without -C - engine bypass due to convolver and notice pop-up appears

I had this in a new branch called low_latency. I am planning on adding some other commits to that branch, so you may want to add a similar one to your repo if you think this is an acceptable pull request.

brummer10 commented 3 years ago

Hi @Rippert

I'll do a cherry picking on this pull request, because the new bool warn_disabled should be a bitmask flag in the OverloadType enum instead.

Rippert commented 3 years ago

Yeah, I flipped a coin in my head about whether you would want me to screw with your bitmask. I guessed wrong. Thanks for accepting the idea.