search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
235 stars 24 forks source link

Guitarix still requires python 2.7 to build #66

Closed hfiguiere closed 3 years ago

hfiguiere commented 3 years ago

You can't build Guitarix from git without having python 2.7

Python 2.7 has been deprecated for a while now.

libgxwmm/gxwmm/wscript require pygobject-2.0 and then call python2 explicitely.

gitterdude commented 3 years ago

It builds fine on Ubuntu 21.04, which doesn't have python2 by default.

hfiguiere commented 3 years ago

--generate-cpp-wrapper is what triggers it

gitterdude commented 3 years ago

To be fair, the help info for --generate-cpp-wrapper clearly states (Developers only!!)

But I agree that it probably should be fixed.

hfiguiere commented 3 years ago

Tell me about it.

Python 2.7 is still deprecated.

brummer10 commented 3 years ago

what we do is call generate_wrap_init.pl which is part of glibmm. This one requires python 2.7, unfortunately. But true is, you'll never ever require that to build guitarix, more over, it is discouraged to do so. (Developers only!!) @hfiguiere if you work on gxlib/mm let me know, and I'm sure we find a way to implement what you are looking for. regards hermann

hfiguiere commented 3 years ago

.pl is Perl

hfiguiere commented 3 years ago

the tl;dr, it want pygobject2 for h2def.py, which is run explicitely using python2. h2def.py exists with recent glibmm, albeit it doesn't seem to be installed anywhere.

brummer10 commented 3 years ago

Ah, yes, true it's h2def.py we call. True is, it wouldn't work with pygobject-3.0 and python3 as there is no h2def.py in there. So what should we do?

hfiguiere commented 3 years ago

I think the approach I was looking at is to copy the glibmm version of the scripts and use them.