search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
265 stars 30 forks source link

Please make all python shebang lines use /usr/bin/env #97

Open yurivict opened 2 years ago

yurivict commented 2 years ago

Currently they are different:

$ grep python /disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/* | grep bin
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/check_rpc:#! /usr/bin/env python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/convert-0.06-format:#! /usr/bin/env python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/coverage:#! /usr/bin/python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/dsp2cc:#! /usr/bin/python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/dsp2insert:#! /usr/bin/python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/dsp2insert:#! /usr/bin/python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/gcov.py:#! /usr/bin/env python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/make_jsonrpc_methods:#! /usr/bin/env python
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/tube_transfer.py:#!/usr/bin/python3
/disk-samsung/freebsd-ports/audio/guitarix-lv2/work/guitarix-0.43.0/tools/undiag:#! /usr/bin/env python

IMO, the preferred form should be

!/usr/bin/env python3

brummer10 commented 2 years ago

Hi yuri Those are all developer tools, which you barley needs to use or distribute within a distribution package. However, you are right, sooner or later we need to follow that advice.