search

brunano21 / angular-4-data-table

An Angular 5 data table, with pagination, sorting, expandable rows, row selection, etc. with basic accessibility support.
MIT License
11 stars 19 forks source link

Buttons not styled correctly #20

Closed Kailayla closed 6 years ago

Kailayla commented 6 years ago

I just started out with this library for a project I'm working on. I just can't get the buttons to style correctly. They look just like little rectangles sitting there. I got Bootstrap and included the style in the angular-cli.json as seen in another issue topic. Now it looks like this. screenshot 83 _blur I missed a styling thing somewhere, but it's unclear to me what.

Also, why is this repo called angular4 when it's angular5? And the demo isn't angular 5 either.

brunano21 commented 6 years ago

Hi, most likely you are missing font-awesome@4.7.0 dependency. You can run npm install font-awesome@4.7.0 and then be sure to have something similar into your .angular-cli.json:

....
      "styles": [
        "../node_modules/bootstrap/dist/css/bootstrap.min.css",
        "../node_modules/font-awesome/css/font-awesome.css",
        "styles.css"
      ],
....

The repo originally was based on Angular4 and it gave the repo name. Then I upgraded the library to Angular5 and then decided to publish it on NPM.

Regarding the demo, I did not provide any demo - the one that you see is probably someone else's demo.

Kailayla commented 6 years ago

Ah yes, that was indeed the ony thing I missed. Thank you!