search

brunano21 / angular-4-data-table

An Angular 5 data table, with pagination, sorting, expandable rows, row selection, etc. with basic accessibility support.
MIT License
11 stars 19 forks source link

Error with prod build #27

Closed codegagan closed 6 years ago

codegagan commented 6 years ago

My application runs fine with ng serve but failing with --prod build:

ERROR in node_modules\angular5-data-table\angular5-data-table.d.ts.DataTablePagination.html(3,11): : Argument of type 'number | "0"' is not assignable to parameter of type '(substring: string, ...args: any[]) => string'. Type 'number' is not assignable to type '(substring: string, ...args: any[]) => string'.

brunano21 commented 6 years ago

@codegagan, ops, I'll fix that, unless you want submit a PR. :-)

codegagan commented 6 years ago

@brunano21 , I already submitted two PRs referenced above. Please accept whichever you like.

codegagan commented 6 years ago

Also please update the library to npm asap, My application is blocked on aot buiilds because of this. Thanks

codegagan commented 6 years ago

When do you plan to review the PR, please let me know if any changes are required ?