Font awesome v 5.0.0 and up not supported on sorting icons

brunano21 / angular-4-data-table

An Angular 5 data table, with pagination, sorting, expandable rows, row selection, etc. with basic accessibility support.

MIT License

11 stars 19 forks source link

Font awesome v 5.0.0 and up not supported on sorting icons #34

Closed smitfrancois closed 6 years ago

smitfrancois commented 6 years ago

We are facing issues with icons not displaying from font awesome v 5.0.0.0.

When I look at the html after the code has rendered I see the following:

but the icon class name has changed to

Please advise?

Regards

brunano21 commented 6 years ago

Hi, the library supports only font-awesome v4.x

Unfortunately sort-desc was renamed to sort-down in v5.x.

smitfrancois commented 6 years ago

Yeah thanks. I only saw on your readme file after I logged the issue. Found a work around. Thanks. Will there be any plans in future to implement support for V.5.x?