search

brunano21 / workspacemechanic

Automatically exported from code.google.com/p/workspacemechanic
0 stars 0 forks source link

Dump keybindings does nothing 0.3.2 eclipse 4.2 #94

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
On ubuntu 12.04 64bit with eclipse 4.2, the dump keybindings dialog does 
nothing when you click okay.

Original issue reported on code.google.com by david.st...@gmail.com on 7 Aug 2012 at 9:57

GoogleCodeExporter commented 9 years ago 
Z, do you think you can look at this?

Original comment by konigsb...@gmail.com on 8 Aug 2012 at 2:25

GoogleCodeExporter commented 9 years ago 
Sorry for the delay in checking this, and thanks for the report.

Konig-man, will you please review and submit this patch? Here's the description:

*******

Gracefully handle requests to remove system bindings that do not exist anymore.

Also change code to catch any Exception and report it as an error. The error 
dialog (at least on 3.8) seems to need some love, but it at least provides 
user-feedback for the click-ok action, which would otherwise simply appear as 
not doing anything.

*********

Original comment by zorze...@gmail.com on 29 Aug 2012 at 6:14

Attachments:

GoogleCodeExporter commented 9 years ago 
Z, what exceptions are thrown that you just catch generic Exception?

Original comment by konigsb...@gmail.com on 29 Aug 2012 at 7:07

GoogleCodeExporter commented 9 years ago 
Well, I wanted to catch IOException (as it was) or RuntimeException, but (until 
java 7) there's no good syntax for that. I don't see any harm in catching 
Exception here, though, as I want to do the same thing no matter what: present 
an error dialog (unless, of course, we get an Error, like OutOfMemory)

Original comment by zorze...@gmail.com on 29 Aug 2012 at 8:27

GoogleCodeExporter commented 9 years ago 
LGTM

Original comment by konigsb...@gmail.com on 29 Aug 2012 at 8:31

GoogleCodeExporter commented 9 years ago 
Patch submitted.

Robert, let us know when a new release is cut that has this fix in. Also, I 
bungled my submit (push), and there's a "foo" branch now in the server that I 
don't know how to get rid of.

Original comment by zorze...@gmail.com on 29 Aug 2012 at 8:48

GoogleCodeExporter commented 9 years ago 
This has been pushed to the testing repository.

Original comment by konigsb...@gmail.com on 1 Sep 2012 at 12:34

GoogleCodeExporter commented 9 years ago 
I just installed from the testing repository and this works as expected now. 
Thanks very much for the fix!

Original comment by david.st...@gmail.com on 9 Sep 2012 at 1:01

GoogleCodeExporter commented 9 years ago 
Pushed to stable repository as 0.3.3.

Original comment by konigsb...@gmail.com on 9 Sep 2012 at 3:28