search

brunch / auto-reload-brunch

Adds automatic browser reloading support to brunch.
88 stars 30 forks source link

reloadWhitelistedJs triggers whitelisted <script>s when data-autoreload=true #79

Closed proger closed 7 years ago

proger commented 7 years ago

I have no idea how this interacts with hot/HMR.

denysdovhan commented 7 years ago

Please, can you give me a better explanation about this PR.

If I understood your correctly, this PR adds ability to reload scripts which are marked using data-autoreload attribute, right?

<script data-autoreload="true">
  console.log('from markup!');
</script>

Why did you decide to name it as reloadWhitelistedJs?

Can you, please, check how this affects to HMR?

proger commented 7 years ago

I decided not to pursue this. Sorry for the noise.