brunch / brunch.github.io

The website
https://brunch.io
MIT License
113 stars 99 forks source link

Broken routing #233

Closed denysdovhan closed 7 years ago

denysdovhan commented 7 years ago

As @denar90 noticed, we have broken routing with development mode. I suppose this issue is related to problems with navigation using iframe. Gonna try to fix that.

Step to reproduce:

  1. git clone https://github.com/brunch/brunch.github.io && cd brunch.github.io
  2. git checkout source
  3. npm install
  4. npm start
  5. Go to http://localhost:3333 and then click any internal link. You'll stay at the home page anyway.

If you really need to go the specific route, please add .html extension after each of route, e.g: http://localhost:3333/docs/getting-startedhttp://localhost:3333/docs/getting-started.html and here you go.

denysdovhan commented 7 years ago

Related question on SO: Remove html extension from GitHub Pages