search

brunch / brunch.github.io

The website
https://brunch.io
MIT License
114 stars 99 forks source link

Correct order of plugin execution pipeline #271

Closed allansson closed 7 years ago

allansson commented 7 years ago

I was trying to setup dependency tracking for elm-lang-brunch, and I couldn't get getDependencies to work like I wanted. After digging around in the brunch source code, I came upon the compile function.

My problem was caused by the compile step being executed before getDependencies, and not after as the documentation stated. I find it hard to believe that this is a bug, so I opted to update the documentation instead.

shvaikalesh commented 7 years ago

Hey @allansson, thanks for the PR. It is done that way so compile method could return dependencies to improve compilation speed.

allansson commented 7 years ago

@shvaikalesh I figured that was the reason. Glad I could help!