search

brunch / brunch.github.io

The website
https://brunch.io
MIT License
114 stars 99 forks source link

changing headings #276

Closed nextchessmove closed 6 years ago

nextchessmove commented 6 years ago

Greetings! I found the getting started guide very helpful and overall well done, but the headings were distracting, at least for me. This is my best attempt at making the headings relevant to what's discussed in the section. I think that's important in this case, as newcomers (like myself) are driven to this guide.

I'm not 100% sure my headings are all technically appropriate, so feel free (of course) to tweak or rewrite as necessary or reject the PR.

In any case, nice work on brunch. It's been a pleasure to work with!

shvaikalesh commented 6 years ago

Hey @nextchessmove, thanks for the PR.

I like the grammar part, but I would like to keep the headings (and other informal text): it makes so-called "made with love" expression. Brunch is different from other tools and the guide should highlight that.

I will consider formal subheadings or titles, though.

paulmillr commented 6 years ago

Not interested in changing the lively article to the shitty one.

nextchessmove commented 6 years ago

Sorry! PR wasn't mint to criticize. I read breader with descriptive headings, but probably most people don't carrot all.

Truthfully though, after reading @shvaikalesh's response, I do appreciate more the tone of the guide. Keep it up!