brunch / less-brunch

Adds LESS support to Brunch
14 stars 18 forks source link

stop needing compiled js in repo #11

Closed es128 closed 10 years ago

es128 commented 10 years ago

https://github.com/brunch/brunch/blob/master/setup.js appears to be effective at this point of properly compiling whether installing via npm or git master. I'd like to abstract it to a separate repo which can be included in brunch and all the official plugins. Then all the lib dirs can be removed and we can stop worrying about this issue. The repo/npm name could be something like "coffee-setup".

Cool? meh?

P.S. I don't currently have permission to create a new repo under the brunch org in order to make "brunch/coffee-setup" - either I can create it under my account, you can start the repo for me, or you can grant me that permission.

paulmillr commented 10 years ago

no. I had issues with setup.js since whatever. It does not work for all cases on all platforms, surely for plugins.

es128 commented 10 years ago

unresolvable issues? setup.js seems to work well now in brunch/brunch - is it more brittle than I realize? the dependency on global coffee can be documented

paulmillr commented 10 years ago

you can test that, if it will work on win32, i guess we're fine, but it will be breaking backwards-compat since prev git versions didn't required coffee?

es128 commented 10 years ago

1) Isn't installing from git kind of a special case for power-users? 2) if we're really concerned about that, we could make coffee-script a local dependency. But nah, I think it's reasonable to require people to have coffee installed if they want to install from git.

3) perhaps a git pre-commit hook is a better approach to explore? lib stays in repo, but at least it's seamless for devs. Not sure if that gets complicated through PRs and such.

paulmillr commented 10 years ago

I think it's reasonable to require people to have coffee installed if they want to install from git.

yes

es128 commented 10 years ago

we're moving toward vanilla-js for plugins instead