search

brunch / less-brunch

Adds LESS support to Brunch
14 stars 18 forks source link

Updated less dependency from ~1.6.3 to ~2.2.0. #19

Closed bvauchelle closed 9 years ago

bvauchelle commented 9 years ago

I have updated less dependency from ~1.6.3 to ~2.2.0. The main goal was to benefit from updates of less but also to benefit from the usage of graceful-fs in newer version of less which is supposed to avoid crashes of less compilation due to amount of files opened at the same time (see https://github.com/less/less.js/issues/1106#issuecomment-28204157 ). Due to the changes of the interface for calling less compilation, brunch-less now needs to be in charge of opening the root less file before passing its content to less.render(). I updated tests accordingly.

bvauchelle commented 9 years ago

Many thanks for your review. I have updated my changes accordingly.

es128 commented 9 years ago 
  ․․․․

  3 passing (17 ms)
  1 failing

  1) Plugin should compile and produce valid result:
     AssertionError: expected 'undefinedError:expected undefined to equal \'#header {\\n  color: #4d926f;\\n}\\n\'' to be falsy
bvauchelle commented 9 years ago

Strange... I tested before pushing & double checked just now and I do not reproduce this issue.

es128 commented 9 years ago

Ok I'll check again in a bit. Maybe I didn't update my deps properly.

es128 commented 9 years ago

Thanks. Landed as 31ab1ab8776abe1302f25b8a1f094f481ed03326