search

brunch / less-brunch

Adds LESS support to Brunch
14 stars 18 forks source link

directions for referencing git version of plug in don't work #6

Closed es128 closed 11 years ago

es128 commented 11 years ago

npm doesn't run the prepublish script when a dependency is included from git (see https://github.com/isaacs/npm/issues/3055), so it either needs to be run manually (include directions in readme) or the built lib included in the repo (I assume it would be overwritten by npm in the typical case). Or the direction for including from git could be removed here and in other similar repos.

Don't know what your preference would be, but I think I would go for including the compiled lib.

paulmillr commented 11 years ago

my direction would be switching to javascript I think

es128 commented 11 years ago

Not sure what you mean. Add directions about how to manually run the prepublish script when referencing the git repo, or include the compiled lib/index.js in the repo?

My vote is for the latter as long as it doesn't cause any problems in a typical npm install.

paulmillr commented 11 years ago

include the compiled lib/index.js in the repo

this