search

brunch / node-browser-modules

MIT License
1 stars 1 forks source link

Buffer.slice does not work as expected #4

Closed rj-xy closed 4 years ago

rj-xy commented 6 years ago

Using Chrome Version 64.0.3282.140 (Official Build) (64-bit)

if I have a variable myBuffer which is a Uint8Array(64): When: myBuffer.slice(0,32) returns a Uint8Array(64), when it should be Uint8Array(32).

This is a significant problem when using bitcoinjs-lib, the following returns the error "Private key must be less than the curve order" var root = bitcoin.HDNode.fromSeedHex('dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd');

The following PR should fix the issue: https://github.com/brunch/node-browser-modules/pull/2

The current workaround is to update the package-lock.json in my project so that Buffer version 5.0.8 is used instead of 4.3.1

paulmillr commented 4 years ago

Done.