search

bruno-chavez / restedancestor

restedancestor is a pretty simple REST API, responds with quotes from Darkest Dungeon.
MIT License
6 stars 8 forks source link

Added new routes #4

Closed prytoegrian closed 6 years ago

prytoegrian commented 6 years ago

Cf. #1

Hi ! Following #1, I added some new routes. They are neither very useful nor interesting, but I hope they could entertain someone. Now, each QuoteType has a score and a uuid for sort and selection purpose. I added :

The routes /one/{uuid}/like and /one/{uuid}/dislike don't follow ReST best practices since this principle forbid verbs in routes but I failed to find a way to represent what I wanted to build. If you have any idea, I'll take it with pleasure.

If, for a reason or another, you don't approve this PR, I won't mind. I really enjoyed play with your software and practice my golang.

Regards.

bruno-chavez commented 6 years ago

Hey I just tested this fork, this is really cool, thanks for the PR!

prytoegrian commented 6 years ago

You're welcome, thanks to you !

prytoegrian commented 6 years ago

Hum, I just saw you reverted the PR (I wanna use master to add some tests). Did you find any bugs in my code ?

bruno-chavez commented 6 years ago

I reverted the PR on master since I wanted to re-structure the project to better accommodate your changes, until then I made a separate branch with all your changes.

bruno-chavez commented 6 years ago

@prytoegrian just pushed to main all your changes, made some minor fixes, thanks for your time!