search

bruno-garcia / log4net.ElasticSearch

log4net appender to ElasticSearch
https://bruno-garcia.github.io/log4net.ElasticSearch/
Other
219 stars 92 forks source link

You shouldn't just do nothing when catching an Exception #111

Closed msaccone closed 4 years ago

msaccone commented 5 years ago

https://github.com/jptoto/log4net.ElasticSearch/blob/c4e3c80d4388fcdb6dfb49cacf4afc3756159a08/src/log4net.ElasticSearch/Repository.cs#L45

I've been working with this plugin, and faced a certificate self signed issue.

I didn't have any clue because of this void catch.

bruno-garcia commented 4 years ago

Agreed. We should let it bubble up. The Appender actually supresses all exceptions while logging them to log4net.Core

bruno-garcia commented 4 years ago

Published as 2.6.0-preview