search

bruno-garcia / log4net.ElasticSearch

log4net appender to ElasticSearch
https://bruno-garcia.github.io/log4net.ElasticSearch/
Other
219 stars 92 forks source link

Feature/netstandard20 compatibility #98

Closed sdragos closed 5 years ago

sdragos commented 6 years ago

@jptoto , psake should work provided that AppVeyor is configured to use a Visual Studio 2017 environment, tests should be running as they work fine on my machine (they run for both net45 and netcoreapp2.0 runtimes), not sure if I got the Nest attributes right on LogEvent, please check them. Ignore the branch name as I tried to target netstandard1.3 and ended up doing netstandard2.0 due to compatibility reasons.

jptoto commented 6 years ago

Thanks for the PR! I'm gonna take a look at this tonight :+1:

jptoto commented 6 years ago

Tests pass from psake (yay!) but for some reason Test Explorer in VS won't find them. Probably a config I should look at. This is great work, thanks!

I'm thinking of bumping the version to 3.0.0 since this is a pretty big release to add netstandard support.

sdragos commented 6 years ago

That's weird, I used the latest Visual Studio update and it worked for me, could you check if you need an update? Not sure about the version bump, code structure wise it is a big change, but user wise not really, they'll get the same thing, that's working in the same way.

sdragos commented 6 years ago

About your review comment, I don't know if it is more typical to have everything in the csproj, but I know that you can edit the new type of csproj directly in Visual Studio while the project is loaded, so in my opinion it makes sense to have versioning and packaging information in it.

aregaz commented 5 years ago

It seems that this PR has been abandoned. Am I right? Do you have any suggestions what I can use instead for dotnet Core 2.1?

sdragos commented 5 years ago

If @jptoto decides to integrate this he should ping me to update the code with the latest changes. Since it took too long to integrate I just published my code on a private feed and used that.

jptoto commented 5 years ago

Hello! I finally came back to this. Apologies for the long wait. This is a great PR and thank you. I pushed this as 2.4.0-beta in the nuget gallery. If I do not hear any complaints I will merge it with master and update the release version. Thanks again!