brunoalano / aiowhois

Asyncio-based Implementation of WHOIS Protocol
MIT License
1 stars 2 forks source link

This module is an example of how not to code #2

Open syleishere opened 3 years ago

syleishere commented 3 years ago

Author chooses to subprocess the whois C binary in background, that is not async TCP connections to whois servers, this is very expensive forks and using someone else's code to do all the work. He wraps the response and prints it out, and choses not to even include email in his parses.

You could do his whole module with: import subprocess ; list_stuff = subprocess.run(["whois", "blah.com"]) and process list_stuff yourself for what you want better than using this.

Author needs to seriously look at modules on CPAN written in perl or C source code of whois binary and do this correctly.

This is an embarrassment to python community.

acidvegas commented 10 months ago

FUCKING SHIT ON LOL