Update UMD definition

[Raruto]

The current definition does not allow an easy usage in module contexts, for example the following throws "root" is undefined error:

<script type="text/javascript">

  import('https://unpkg.com/leaflet.fullscreen').then(()=>{ /* do stuff */ });

</script>

also when using bundlers (eg. rollup) you requires some special caveats, eg:

  moduleContext: { "node_modules/leaflet.fullscreen/Control.FullScreen.js": "window" },

Reference:

• https://github.com/umdjs/umd/templates/amdWeb.js
• https://caniuse.com/?search=self

Alternatively you could use the globalThis variable as well:

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis
• https://caniuse.com/?search=globalThis

Have a nice day, Raruto

[brunob]

Thx for the PR and the explanation, any thoughts on this @BePo65 ?

[BePo65]

I do not completely understand in what context @Raruto uses this plugin.

The current definition does not allow an easy usage in module contexts

Are you trying to use it in an esm context?

Besides this, I have to run some tests to find out, if the proposed changes do have side effects (that I do not expect). Give me a few days for this :-)

[brunob]

Besides this, I have to run some tests to find out, if the proposed changes do have side effects (that I do not expect). Give me a few days for this :-)

Again, thx a lot @BePo65 since i'm far away all these considerations.

[Raruto]

@BePo65 currently i am using it as static import within the leaflet-ui plugin (but to work properly with rollup it still requires you to use the moduleContext transformation, which essentially rewrites the this keyword to window). Anyway, I'm experimenting with dynamic imports, in a similar manner to the following:

<script type="text/javascript">

  import('https://unpkg.com/leaflet.fullscreen').then(()=>{ /* do stuff */ });

</script>

And also in this case, since we are always in a module context (esm), the variable this is undefined.

https://github.com/brunob/leaflet.fullscreen/blob/d1f12fa4432bb2225979ff4051e65e647056b7d1/Control.FullScreen.js#L18

Give me a few days for this :-)

No hurry, I noticed it years ago and I never thought about doing a pull request

Raruto

[BePo65]

Made some tests with web browser and commonjs and as expected there are no errors. So @brunob I would recommend to merge this pr.

And I would be glad to get some feedback from @Raruto, if errors should appear after publishing this modification.

[brunob]

Thx for the feedback @BePo65 ! I'll merge and release this one of these days :)

[brunob]

Merged and released as 2.3.0 thx @Raruto & @BePo65 :)