search

brunob / leaflet.fullscreen

Leaflet.Control.FullScreen for Leaflet
https://brunob.github.io/leaflet.fullscreen/
MIT License
383 stars 111 forks source link

CDNs stopped distributing the full screen icon after the project switched to SVG #112

Closed afontenot closed 1 year ago

afontenot commented 1 year ago

Compare:

https://cdnjs.cloudflare.com/ajax/libs/leaflet.fullscreen/2.1.0/icon-fullscreen.png

https://cdnjs.cloudflare.com/ajax/libs/leaflet.fullscreen/2.2.0/icon-fullscreen.svg

Is there anything we can do to get the CDNs to distribute leaflet.fullscreen with the icon again? The result of this issue is that anyone using a CDN for this project will have a blank icon.

afontenot commented 1 year ago

Actually, apologies, this looks like just an issue with cdnjs. I've submitted a PR that should fix this. https://github.com/cdnjs/packages/pull/1667

brunob commented 1 year ago

Nice catch, i think we can close here.

afontenot commented 1 year ago

@brunob do you think its worthwhile to push a point release to fix this on cdnjs? My PR was merged but changes aren't retroactively applied to previous releases (in part because the SRI hash is supposed to be static). If you bump to 3.0.1 the new icon should be picked up. This is probably not urgent if you would rather just wait for the next release.

brunob commented 1 year ago

This is probably not urgent if you would rather just wait for the next release.

I think so :)