brunob / leaflet.fullscreen

Leaflet.Control.FullScreen for Leaflet
https://brunob.github.io/leaflet.fullscreen/
MIT License
376 stars 107 forks source link

add important eslint rules from leaflet repository and fix resulting warnings #116

Closed BePo65 closed 11 months ago

BePo65 commented 11 months ago

My intention for this pr was to make this repo even better, but feel free to just ignore it 😄.

To make eslint rules more consistent with leaflet, this pr adds the rules from the leaflet repository that are handled as errors and fixes the resulting warnings,

Besides this it:

KristjanESPERANTO commented 11 months ago

I suggested a more extensive approach adding prettier and stylelint with #115. What do you think of it?

It might also be a good option to merge your PR and then I rebase my PR to discuss the introduction of prettier and stylelint later?

BePo65 commented 11 months ago

This pr is no longer necessary - I support pr #115 instead