Fix full-screen map when browser is full-screen

brunob / leaflet.fullscreen

Leaflet.Control.FullScreen for Leaflet

https://brunob.github.io/leaflet.fullscreen/

MIT License

376 stars 107 forks source link

Fix full-screen map when browser is full-screen #122

Closed gjvoosten closed 4 months ago

gjvoosten commented 5 months ago

Fixes brunob/leaflet.fullscreen#121

gjvoosten commented 5 months ago

@brunob Anything I can do to help get this merged and released?

brunob commented 5 months ago

@brunob Anything I can do to help get this merged and released?

Thx for the issue and the PR, just let me a couple of days to find a moment to review it.

gjvoosten commented 4 months ago

I hate to ask (again), @brunob, but any progress on this?

brunob commented 4 months ago

The fix seems good, but i have a doubt on performance impact of calling invalidateSize() every times. Any thoughts @BePo65 ?

gjvoosten commented 4 months ago

The fix seems good, but i have a doubt on performance impact of calling invalidateSize() every times. Any thoughts @BePo65 ?

Not sure what you mean by "every time". The calls to invalidateSize() only happen upon entering full-screen (via the button), and upon exiting full-screen (both via the button and via the Escape key).

BePo65 commented 4 months ago

IMHO @gjvoosten is right: invalidateSize() should be triggered only, when the fullscreen state changes. So I do not see any performance penalties.

brunob commented 4 months ago

Nice, let's merge this :)

brunob commented 4 months ago

published with version 3.0.2, thx again @gjvoosten !