search

brunob / leaflet.fullscreen

Leaflet.Control.FullScreen for Leaflet
https://brunob.github.io/leaflet.fullscreen/
MIT License
383 stars 111 forks source link

Update devDependencies and add dependabot config #126

Closed KristjanESPERANTO closed 4 months ago

KristjanESPERANTO commented 4 months ago

As we only have devDependencies, a monthly dependabot check should be sufficient.

Since a few ESlint plugins have not yet been completely converted to ESlint 9, we get a few "Conflicting peer dependency" warnings with "npm install". I think we can ignore these warnings though.

brunob commented 4 months ago

Thx, i think we should follow conventionnal commit in the future :)

brunob commented 4 months ago

Since a few ESlint plugins have not yet been completely converted to ESlint 9, we get a few "Conflicting peer dependency" warnings with "npm install". I think we can ignore these warnings though.

Strange, all warnings comes from @typescript-eslint/utils which seems related to @eslint/js. since we don't use typescript, maybe there is way to exclude this dep ? FTR, I don't get this kind of error with this eslint config which i've updated yesterday https://github.com/leaflet-extras/leaflet-providers/blob/master/eslint.config.js

KristjanESPERANTO commented 4 months ago

Thx, i think we should follow conventionnal commit in the future :)

Okay, I didn't know about this before :+1: All linting stuff is chore, right?

FTR, I don't get this kind of error with this eslint config which i've updated yesterday

That's because we use @stylistic/eslint-plugin here instead of @stylistic/eslint-plugin-js. I've created a PR to switch to @stylistic/eslint-plugin-js: #127

brunob commented 4 months ago

Okay, I didn't know about this before 👍 All linting stuff is chore, right?

It depends... for me Update dependencies => build & Add dependabot => chore & Switch to modern ES import => test or ci.

We have published a detail of every types in french here https://www.spip.net/fr_article6824.html

That's because we use @stylistic/eslint-plugin here instead of @stylistic/eslint-plugin-js. I've created a PR to switch to @stylistic/eslint-plugin-js: https://github.com/brunob/leaflet.fullscreen/pull/127

Nice !