search

brunob / leaflet.fullscreen

Leaflet.Control.FullScreen for Leaflet
https://brunob.github.io/leaflet.fullscreen/
MIT License
376 stars 107 forks source link

Not working on Safari 14 #92

Closed MarioAda closed 2 years ago

MarioAda commented 3 years ago

I've tested screenfull.js on Safari 14, and it works fine on: https://sindresorhus.com/screenfull.js/ However, Control.Fullscreen.js doesn't work

brunob commented 3 years ago

Tested https://brunob.github.io/leaflet.fullscreen/ with Safari 14.1.2 on Max OS 10.14.6 and it works.

Do you have any error in the console ?

MarioAda commented 2 years ago

@brunob After debugging Control.Fullscreen.js, the event was firing twice on the latest Safari, and so as soon as it enters fullscreen, it exits. To fix it, I had to set tap = false on the Leaflet map. Try it out on the latest Safari, not 14.1.2, and you'll see for yourself.

brunob commented 2 years ago

Seems related to https://github.com/Leaflet/Leaflet/issues/7255

Have you tried with this patch https://github.com/Leaflet/Leaflet/pull/7260 on Leaflet ?

brunob commented 2 years ago

@MarioAda any news about this ?

MarioAda commented 2 years ago

@brunob, sorry I haven't tried it yet, but you might be right. I'll be looking into it this week

brunob commented 2 years ago

No feedback, closing, feel free to comment if needed.