search

brunob / leaflet.fullscreen

Leaflet.Control.FullScreen for Leaflet
https://brunob.github.io/leaflet.fullscreen/
MIT License
376 stars 107 forks source link

switch to a SVG icon + toggling icon status #98

Closed brunob closed 2 years ago

brunob commented 2 years ago

use icon from https://github.com/Leaflet/Leaflet.fullscreen optimised with https://jakearchibald.github.io/svgomg/

ref #97 & #87

Maybe we should use icons from https://remixicon.com/ but for a first shot it seems good to me like this...

Any thoughts @hswong3i & @skirridsystems ?

skirridsystems commented 2 years ago

Works for me. I always liked the icon used by Leaflet.fullscreen.

hswong3i commented 2 years ago

With #97 research progress, I would like to suggest NOT using Leaflet.fullscreen legacy SVG icon (because their CSS also not using it, but the exported PNG version).

Moreover, I vote for Font Awesome https://fontawesome.com/v5.15/icons/expand and https://fontawesome.com/v5.15/icons/compress, looks much in pair style.

brunob commented 2 years ago

Thx for the feedback, @hswong3i i've compressed the SVG from Leaflet.fullscreen 5.89 KB => 442 Bytes

I also like Font Awesome alternative (which are similar to the shape proposed by https://remixicon.com/ fullscreen icons), but i also think that's a good thing to use the same icon than Leaflet.fullscreen :\

brunob commented 2 years ago

Here is an alternative icon using fontawesome if you want to give it a try. It feel better on eyes cause the stroke seems a bit bolder, but it's also a bigger file 945 bytes (compared to the 442 bytes of the one in this PR).

<svg viewBox="0 0 26 52" xmlns="http://www.w3.org/2000/svg"><path d="M20.6 36.7H16a.9.9 0 0 1-.8-.8v-4.5c0-.2.2-.4.4-.4h1.4c.3 0 .5.2.5.4v3h3c.2 0 .4.2.4.5v1.4c0 .2-.2.4-.4.4zm-9.9-.8v-4.5c0-.2-.2-.4-.4-.4H8.9c-.3 0-.5.2-.5.4v3h-3c-.2 0-.4.2-.4.5v1.4c0 .2.2.4.4.4H10c.4 0 .8-.4.8-.8zm0 10.7V42c0-.4-.4-.8-.8-.8H5.4c-.2 0-.4.2-.4.4v1.4c0 .3.2.5.4.5h3v3c0 .2.2.4.5.4h1.4c.2 0 .4-.2.4-.4zm6.9 0v-3h3c.2 0 .4-.2.4-.5v-1.4c0-.2-.2-.4-.4-.4H16c-.4 0-.8.4-.8.8v4.5c0 .2.2.4.4.4h1.4c.3 0 .5-.2.5-.4zM5 10.3V5.9c0-.5.4-.9.9-.9h4.4c.2 0 .4.2.4.4V7c0 .2-.2.4-.4.4h-3v3c0 .2-.2.4-.4.4H5.4a.4.4 0 0 1-.4-.4zm10.3-4.9V7c0 .2.2.4.4.4h3v3c0 .2.2.4.4.4h1.5c.2 0 .4-.2.4-.4V5.9c0-.5-.4-.9-.9-.9h-4.4c-.2 0-.4.2-.4.4zm5.3 9.9H19c-.2 0-.4.2-.4.4v3h-3c-.2 0-.4.2-.4.4v1.5c0 .2.2.4.4.4h4.4c.5 0 .9-.4.9-.9v-4.4c0-.2-.2-.4-.4-.4zm-9.9 5.3V19c0-.2-.2-.4-.4-.4h-3v-3c0-.2-.2-.4-.4-.4H5.4c-.2 0-.4.2-.4.4v4.4c0 .5.4.9.9.9h4.4c.2 0 .4-.2.4-.4z" fill="currentColor"/></svg>

You can test it on https://github.com/brunob/leaflet.fullscreen/tree/svg_icon_fa branch