search

brunobord / pomodorock

A single webpage pomodoro timer / tracker that keeps ZERO KNOWLEDGE of your data on the server-side.
http://brunobord.github.io/pomodorock
Do What The F*ck You Want To Public License
18 stars 5 forks source link

Fix issue #21. #23

Closed gillesfabio closed 10 years ago

pquentin commented 10 years ago

I'm afraid this doesn't fix the issue: you now have n JS timers, but only one moment.js time, and only one place to display the time left. It doesn't make sense to be on a break and on a pomodoro at the same time: the fix is really to clear the previous timer when setting a new one.

gillesfabio commented 10 years ago

@pquentin Thanks for your review! The fix fixed the issue but, indeed, was not the KISS way to do so (see timers as intervals, and not "timers" properly). Anyway. I agree with you. I simply added a clearInterval. Much relevant.

pquentin commented 10 years ago

The new version looks great. :) Thank you!

gillesfabio commented 10 years ago

Squashed commits.

gillesfabio commented 10 years ago

Will propose a better PR soon.