brunoborges / javafx-jlink-starter-gradle

A JavaFX starter project with Gradle and jlink support
Apache License 2.0
76 stars 14 forks source link

Non-modular JavaFX projects #1

Open shathor opened 5 years ago

shathor commented 5 years ago

This starter won't work for non-modular projects. The main method should be in a class that doesn't extend Application for now. See http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-June/021977.html

brunoborges commented 5 years ago

This starter is not intended, for now, to work with non-modular projects. But will keep this in mind.

If you can enhance it to do so, happy to review a PR.

shathor commented 5 years ago

Hardly any projects are modular in JPMS sense and there's no sign that the industry will catch on, so I think there's more value when it also works for non-modular projects.

brunoborges commented 5 years ago

Fair statement. I'll investigate further!

siordache commented 5 years ago

@brunoborges This example is a good starting point for implementing a non-modular JavaFX starter project.

@shathor See this FXGL implementation of Pacman for an example of creating a custom runtime image for a complex non-modular JavaFX project.