Creating jLink bundle fails with cannot retrieve module name from module-info.java

[BlueGoliath]

Attempting to run the "jLink" task fails with ``` Execution failed for task ':prepareModulesDir'. Cannot retrieve module name from module-info.java

Besides having to manually delete /build/jlinkbase/tmpmerged every build, the project "runs" from netbeans just fine(via green button). 

The project currently utilizes other local Java 9 modules which are placed in a root/lib folder as seen in the gradle build file:

plugins {
    id 'java'
    id 'application'
    id 'org.openjfx.javafxplugin'      version '0.0.7'
    id 'org.beryx.jlink'               version '2.6.4'
    id 'com.github.ben-manes.versions' version '0.20.0'
}

// Application Configuration
ext {
    appName = "Goliath Envious FX"
    appLauncher = "goliathenviousfx"
    appPackaging = "goliathenviousfx"
    appModuleName = "goliathenviousfx"
    appMainClass = "goliathenviousfx.GoliathENVIOUSFX"
}

mainClassName = "${ext.appModuleName}/${ext.appMainClass}"

repositories {
    mavenCentral()
}

javafx {
    modules = ['javafx.controls']
}

jlink {
    imageZip = project.file("${buildDir}/distributions/${appPackaging}-${javafx.platform.classifier}.zip")
    options = ['--strip-debug', '--compress', '2', '--no-header-files', '--no-man-pages']
    launcher {
        name = "${appLauncher}"
    }
}

dependencies {
    compile files('lib/goliath.envious.jar')
    compile files('lib/goliath.nvsettings.jar')
    compile files('lib/goliath.nvsmi.jar')
    compile files('lib/goliath.nvxconfig.jar')
    compile files('lib/goliath.nvserver.jar')
    compile files('lib/goliath.envious.reactive.jar')
    compile files('lib/goliath.io.jar')
    compile files('lib/goliath.css.jar')
 }

task dist {
    dependsOn clean, jlinkZip
    description "Calls clean and then jlinkZip [default]"
}

defaultTasks 'dist'

I have no experience with Gradle and had just been using Ant via Netbeans previously so maybe it's something i'm doing wrong here.

[brunoborges]

Paste here your version of src/main/java/module-info.java

[brunoborges]

You should've made changes to that as well.

[BlueGoliath]

Here it is:

`module goliathenviousfx { requires javafx.base; requires javafx.controls; requires goliath.envious; requires goliath.nvsettings; requires goliath.nvsmi; requires goliath.nvxconfig; requires goliath.css;

exports goliathenviousfx;

}`

[siordache]

This is a badass-jlink issue, which is fixed in release 2.6.5. You need to put:

id 'org.beryx.jlink' version '2.6.5'

in your build.gradle.

[brunoborges]

Hopefully 17aa25b has this addressed. Thanks @siordache

[BlueGoliath]

Thanks. That fixed that issue, but now i'm getting:

Error: Module goliath.nvsettings not found, required by goliathenviousfx

goliath.nvsettings is a local modular jar. I can't seem to find much information about how to include local modular jars in Gradle. Is it even possible to do?

[brunoborges]

Hoping @aalmiray can help.

[aalmiray]

I've tested with the following setup:

1. clone this repository.
2. add ikonli-javafx and an icon pack as dependencies.
3. modify module-info.java to require ikonli modules.
4. invoke the dist target.
5. run the generated image.

It works as expected. This makes me think that either the goliath modular JARs are not setup correctly (they may not be true modular JARs) or the dependencies are set wrongly. Try using a flatDir repository, like this

repositories {
    mavenCentral()
    flatDir { dir 'lib' }
}

dependencies {
    compile ':goliath.envious:'
    compile ':goliath.nvsettings:'
    compile ':goliath.nvsmi:'
    compile ':goliath.nvxconfig:'
    compile ':goliath.nvserver:'
    compile ':goliath.envious.reactive:'
    compile ':goliath.io:'
    compile ':goliath.css:'
}

[BlueGoliath]

Yes, that works perfectly! Thanks all!