search

brunocodutra / webapp-webpack-plugin

[DEPRECATED] use favicons-webpack-plugin instead
https://www.npmjs.com/package/webapp-webpack-plugin
MIT License
125 stars 17 forks source link

Cache hash should depend on Favicons version #146

Closed wclr closed 5 years ago

wclr commented 5 years ago

Is it possible to hash individual files? The case why:

There is an issue https://github.com/itgalaxy/favicons/issues/253

With different favicons version, the same source file is processed differently. If we hash only by source file we have a situation with a stale cache on a client.

Or icons-[hash] should also depend on exact favicons version.

brunocodutra commented 5 years ago

Or icons-[hash] should also depend on exact favicons version

That's actually a good point, I think it should indeed.

wclr commented 5 years ago

And maybe svg2png or phantomjs =)

brunocodutra commented 5 years ago

I'm not sure about these, since they are transitive dependencies that we don't control.

brunocodutra commented 5 years ago

I think a compromise we can make to improve the situation is to have [hash] depend on the version of webapp-webpack-plugin.