brunocodutra / webapp-webpack-plugin

[DEPRECATED] use favicons-webpack-plugin instead
https://www.npmjs.com/package/webapp-webpack-plugin
MIT License
125 stars 17 forks source link

add rule and loader to get generated tags #158

Closed vonagam closed 5 years ago

vonagam commented 5 years ago

For #156

brunocodutra commented 5 years ago

Any idea why tests are failing on Windows?

vonagam commented 5 years ago

The problem lies in non reproducible builds of js bundle.

To get reproducible builds on my personal machine (mac) i used OccurrenceOrderPlugin, seems it does not help with builds between machines.

brunocodutra commented 5 years ago

What if we teach compare to evaluate main.js (or any file that ends in .js for that matter), similarly to what we do here, and compare the output rather than the contents directly?

vonagam commented 5 years ago

Added some description to README.

Fixed rule tests. Made bundle js output to export tags with cjs so that we can compare them with expected result by simply requiring them.

Offtop: In cache tests you use t.pass(some true value). I think you wanted to use t.true (or t.truthy for length value), because t.pass accepts only message to show, so even if you call t.pass(false) it passes.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 688


Totals Coverage Status
Change from base Build 681: 0.8%
Covered Lines: 102
Relevant Lines: 103

💛 - Coveralls