Apple - larger resolutions not being generated

haganbt commented 5 years ago

Firstly, thanks so much for a fantastic plugin. Huge time saver!

I can see that the larger resolution images are not being generated and hence I get no splash screen on the iPhone XS max or X. Here is a list of what is being generated:

apple-touch-icon-1024x1024.png
apple-touch-icon-114x114.png
apple-touch-icon-120x120.png
apple-touch-icon-144x144.png
apple-touch-icon-152x152.png
apple-touch-icon-167x167.png
apple-touch-icon-180x180.png
apple-touch-icon-57x57.png
apple-touch-icon-60x60.png
apple-touch-icon-72x72.png
apple-touch-icon-76x76.png
apple-touch-icon-precomposed.png
apple-touch-icon.png
apple-touch-startup-image-1182x2208.png
apple-touch-startup-image-1242x2148.png
apple-touch-startup-image-1496x2048.png
apple-touch-startup-image-1536x2008.png
apple-touch-startup-image-320x460.png
apple-touch-startup-image-640x1096.png
apple-touch-startup-image-640x920.png
apple-touch-startup-image-748x1024.png
apple-touch-startup-image-750x1294.png
apple-touch-startup-image-768x1004.png

It looks like I am missing:

1668x2224
2048x2732

Appreciate any guidance. My config:

new WebappWebpackPlugin({
      logo: resolve(__dirname, '../src/client/assets/large-icon.png'),
      favicons: {
        appName: 'foo',
        appDescription:
          'bar',
        developerName: null,
        developerURL: null, // prevent retrieving from the nearest package.json
        background: '#00bbd4',
        theme_color: '#00bbd4',
        icons: {
          // Platform Options:
          // - offset - offset in percentage
          // - background:
          //   * false - use default
          //   * true - force use default, e.g. set background for Android icons
          //   * color - set background for the specified icons
          //   * mask - apply mask in order to create circle icon (applied by default for firefox). `boolean`
          //   * overlayGlow - apply glow effect after mask has been applied (applied by default for firefox). `boolean`
          //   * overlayShadow - apply drop shadow after mask has been applied .`boolean`
          //
          android: true, // Create Android homescreen icon. `boolean` or `{ offset, background, mask, overlayGlow, overlayShadow }`
          appleIcon: true, // Create Apple touch icons. `boolean` or `{ offset, background, mask, overlayGlow, overlayShadow }`
          appleStartup: true, // Create Apple startup images. `boolean` or `{ offset, background, mask, overlayGlow, overlayShadow }`
          coast: false, // Create Opera Coast icon. `boolean` or `{ offset, background, mask, overlayGlow, overlayShadow }`
          favicons: true, // Create regular favicons. `boolean` or `{ offset, background, mask, overlayGlow, overlayShadow }`
          firefox: true, // Create Firefox OS icons. `boolean` or `{ offset, background, mask, overlayGlow, overlayShadow }`
          windows: true, // Create Windows 8 tile icons. `boolean` or `{ offset, background, mask, overlayGlow, overlayShadow }`
          yandex: false
        }
      }
    }),
...

brunocodutra commented 5 years ago

Thanks for reporting - it looks like Favicons needs to be updated upstream to generate the missing resolutions.

haganbt commented 5 years ago

OK, thanks for the clarification.

Skagevang commented 4 years ago

Hi @brunocodutra will this feature be updated or is this repo maintained?

brunocodutra commented 4 years ago

@Skagevang this plugin has been merged back with favicons-webpack-plugin, I recommend you switch to it for the latest updates.

Skagevang commented 4 years ago

@brunocodutra Can't find the rule_loader for webpack in that repo?

brunocodutra commented 4 years ago

Oh well, that might be one of the features that were dropped when the plugins were merged.

This one is deprecated though and I don't have the capacity to maintain it any longer, I suggest requesting the missing features upstream.

brunocodutra / webapp-webpack-plugin

Apple - larger resolutions not being generated #161