brunoerg / bitcoinfuzz

Differential Fuzzing of Bitcoin implementations and libraries
32 stars 12 forks source link

Add RPC Target #61

Closed hax0kartik closed 2 months ago

hax0kartik commented 3 months ago

This is a rough draft right now because there are certain areas which need to be improved before merging:

brunoerg commented 3 months ago

Still draft or ready for review?

brunoerg commented 3 months ago
In file included from init.cpp:25:
./httpserver.h:134:43: error: no matching constructor for initialization of 'std::span<typename string_view::value_type>' (aka 'span<char>')
        WriteReply(nStatus, std::as_bytes(std::span{reply}));
hax0kartik commented 3 months ago

Still draft or ready for review?

I believe I am ready for review

hax0kartik commented 3 months ago
In file included from init.cpp:25:
./httpserver.h:134:43: error: no matching constructor for initialization of 'std::span<typename string_view::value_type>' (aka 'span<char>')
        WriteReply(nStatus, std::as_bytes(std::span{reply}));

Are you compiling with the most recent commit of bitcoin core? I tested commit 60b816439e and I see no such issues.

brunoerg commented 3 months ago

Are you compiling with the most recent commit of bitcoin core? I tested commit 60b816439e and I see no such issues.

Yes, and tried on master.