Closed hax0kartik closed 2 months ago
Still draft or ready for review?
In file included from init.cpp:25:
./httpserver.h:134:43: error: no matching constructor for initialization of 'std::span<typename string_view::value_type>' (aka 'span<char>')
WriteReply(nStatus, std::as_bytes(std::span{reply}));
Still draft or ready for review?
I believe I am ready for review
In file included from init.cpp:25: ./httpserver.h:134:43: error: no matching constructor for initialization of 'std::span<typename string_view::value_type>' (aka 'span<char>') WriteReply(nStatus, std::as_bytes(std::span{reply}));
Are you compiling with the most recent commit of bitcoin core? I tested commit 60b816439e
and I see no such issues.
Are you compiling with the most recent commit of bitcoin core? I tested commit 60b816439e and I see no such issues.
Yes, and tried on master.
This is a rough draft right now because there are certain areas which need to be improved before merging:
Initialization : Preferably, we should report to the user in case the btcd server has not been executed yet. +1 if we can launch the server ourselves.
Code Cleanup : Minor Code cleanup is needed