brunoherbelin / vimix

Live Video Mixer
GNU General Public License v3.0
259 stars 25 forks source link

seek OSC message problem #110

Closed lupin3rd closed 7 months ago

lupin3rd commented 7 months ago

I'm writing a module in Chataigne to communicate by OSC with Vimix... i'm testing all messages and seem that SEEK don't works correctly... i send a float from 0 to 1 but seem that always video run to begin... I'm using beta branch.

brunoherbelin commented 7 months ago

aha.. Before I investigate further, maybe it is a miscommunication in the documentation (https://github.com/brunoherbelin/vimix/wiki/Open-Sound-Control-API) of what the float parameter should indicate : it is a value between 0.0 and 1.0, for the percentage of duration of the video.

e.g. this instruction :

/vimix/current/seek f 0.5

will seek to the position at 50% of the total duration (not at 0.5 seconds).

Thanks for confirming this is clear and replicates the bug

lupin3rd commented 7 months ago

I followed documentation but if i send 0.5 seek don't go on 50% but at begin... i try to create a video...

brunoherbelin commented 7 months ago

ok, then I will check and fix the bug ! sorry for that.

lupin3rd commented 7 months ago

I'm writing a Chataigne module... i'm testing and then i release on github... https://youtu.be/SCK7jnKc1nI

brunoherbelin commented 7 months ago

Please update to Beta f497da79676aeb950360bc2956ef675106d730ff

It should be fixed! I didn't test extensively but the code was obviously incorrect... NB: seek to 1.0 is causing a return to 0 if the source is in loop play mode.

brunoherbelin commented 7 months ago

And very cool the module for Chataigne :smile:

lupin3rd commented 7 months ago

I confirm that the problem is fixed! Thank you.

brunoherbelin commented 7 months ago

NB: Seek had more hidden problems and I worked a bit on it. Thanks for checking that things are still working as expected with Beta cf3bceeb46423e2084369e4f47ae3f09b28dce37

The OSC documentation was also updated; you can see there is a new seek syntax to target a specific time in HH:MM:SS format