brunoherbelin / vimix

Live Video Mixer
GNU General Public License v3.0
259 stars 25 forks source link

seek OSC message behavior #120

Closed lupin3rd closed 4 months ago

lupin3rd commented 5 months ago

I think that seek message must "move" clip only on active parts. Actually if i cut some video segment on media player and try to use seek message from 0 to 1 if i send numeric message that is inside the cut segment vimix play always the begin of active video... i think that 0 to 1 must be only the not cutted video segment.

brunoherbelin commented 5 months ago

I see, but what would you suggest when video has multiple segments?

image

According to what you suggest, the [0..1] target should consider the % of the playable accumulated segment? Or the seek command should specify the % and the index of the segment (e.g. seek(1, 0.5) for 50% of segment 1) ?

lupin3rd commented 5 months ago

According to what you suggest, the [0..1] target should consider the % of the playable accumulated segment?

Yes. I suggest this solution. But...

Or the seek command should specify the % and the index of the segment (e.g. seek(1, 0.5) for 50% of segment 1) ?

...also this solution is very interesting. You could implement both solution? seek(0, X.X) the % playable of all segments seek(1, X.X), seek(2, X.X) the % of single segment

brunoherbelin commented 5 months ago

Thanks!. OSC seek with percent is now behaving as expected, i.e. the target [0..1] seeks to a % of the actual playing segments (discarding cut segments). API documentation updated.

Please try Beta 842247de547ec98391853500fa2be2002e268995 and let me know : it seems to work for me, but maybe there are still problems..

lupin3rd commented 4 months ago

I confirm that now seek works only with playing segments. No problem... i try a lot with random OSC messages.