search

brunomikoski / Animation-Sequencer

A visual tool that allows you to create animated sequences of tweens and tweak them on editor time.
MIT License
960 stars 116 forks source link

'DOTweenEditorPreview' does not contain a definition for 'isPreviewing' #27

Closed nindim closed 3 years ago

nindim commented 3 years ago

Hey @brunomikoski ,

Just trying out version 0.2.4 with DOTween 1.2.632 and getting this:

Assets\Animation-Sequencer\Scripts\Editor\Core\AnimationSequencerControllerCustomEditor.cs(113,38): error CS0117: 'DOTweenEditorPreview' does not contain a definition for 'isPreviewing'

image

Did you manually edit DOTween to expose this?

All the best.

brunomikoski commented 3 years ago

I just tested both 0.24 of the sequencer and DOTween 1.2.632 and both are working here, are you sure you created the asmdef files from the DOTween Setup Panel?

nindim commented 3 years ago

Hey @brunomikoski ,

Yeah, I definitely did that as I was getting other errors prior to that.

Using Rider to peek into the DOTween code, only _isPrviewing exists and it is Private:

image

To repro:

  1. Create new Unity 2019.4.29 3D Project
  2. Import Animation Sequencer 0.2.4
  3. Import the free DOTween from Asset Store - "DOTween (HOTween v2)" - https://assetstore.unity.com/packages/tools/animation/dotween-hotween-v2-27676
  4. Setup DOTween with all tickboxes
  5. Create the .asmdef files.

Repro Project: https://drive.google.com/file/d/1-M51qlSm1JNDETA4n138bXlZ16QyHtKG/view?usp=sharing

All the best.

brunomikoski commented 3 years ago

Looks like DOTween version on Asset Store it outdated: image

Install the version v1.2.632 from their website: http://dotween.demigiant.com/download.php

nindim commented 3 years ago

That's really weird, it does list as the same version in the Asset Store:

Screenshot_20210901-090201

I'll give the version you linked a shot.

Thanks!

nindim commented 3 years ago

The direct download from the DOTween site has resolved this, thank you.

Demigiant commented 3 years ago

Holy cow I'm so sorry, also for not seeing this sooner! I just checked and the Asset Store reports the right package uploaded so I don't understand what happened, but I'll re-upload a newer version within the week (which also has a few nicer additions) 👀

Demigiant commented 3 years ago

Uhm, but wait, I just tried downloading DOTween from the Asset Store, using Unity 2019, and I got the right 1.2.632 version. Could you tell me the exact process you followed to download? Maybe there's a specific Asset Store procedure that for some mysterious reason downloads an older version

brunomikoski commented 3 years ago

Maybe was some caching issue? But I noticed this a couple of times with this past release, that said one version on the asset store, but when you download it, was actually a older version

nindim commented 3 years ago

The weird thing is that DOTween itself was telling me I had the newest version in the Utility Panel but it was missing the IsPreviewing functionality.

I wonder if I somehow got a frankenbuild.and that is how I was missing the required functionality... .That said, I'm 99.9% sure I imported it fresh into a new project!