search

brunomikoski / Animation-Sequencer

A visual tool that allows you to create animated sequences of tweens and tweak them on editor time.
MIT License
960 stars 116 forks source link

OnFinishedEvent with a loop is fired at each tick #51

Closed burakomer closed 2 years ago

burakomer commented 2 years ago

When setting a finite loop, the OnFinishedEvent is fired at each tick. I think it should be registered as an OnComplete callback rather than AppendCallback callback.

brunomikoski commented 2 years ago

Sorry that it took me so long to be able to take a look at this, but actually using the OnComplete for this causes other problems when rewinding tween as well. I will investigate this further to try to find a better solution

burakomer commented 2 years ago

Thanks! For the time being, my solution was to set the loop under the step, then add a callback on the next step. This works for simple tweens.

brunomikoski commented 2 years ago

I'm glad you figure out a better way of handling it! I will close the issue for now! :D