search

brunopostle / homemaker-addon

Design buildings the pointy-clicky way, a blender add-on that transforms spatial geometry into IFC building models
GNU General Public License v3.0
125 stars 7 forks source link

Mixed case vs. lower case #40

Open wassimj opened 2 years ago

wassimj commented 2 years ago

I noticed in the property names sometimes it uses MixedCase and sometimes it uses lowercase. For example, StyleName vs. stylename.

brunopostle commented 2 years ago

The lowercase attributes are the internal cellcomplex data, so I never expected them to be exposed. It makes sense to unify them.

I'm giving all the Cells and Faces a unique index number (starting at 0), and putting this in the 'index' attribute. Presumably @wassimj you often need to do the same thing, what namespace do you use?

wassimj commented 2 years ago

I do not have index numbers simply because I can retrieve adjacencies through an API call rather than through lookup in dictionaries. For dictionary keys that Topologic is creating 'on the fly' (i.e. from Blender geometry), I am using uppercase TOPOLOGIC followed by underscore followed by lowercase key name. (e.g. TOPOLOGIC_name, TOPOLOGIC_color, TOPOLOGIC_type). For the IFC values that are not in property sets (e.g. name, globalid, type), I prefix with IFC followed by underscore followed by lowercase key name (e.g. IFC_globalid, IFC_name)