Codecov Report

Merging #113 (9b77b68) into master (f4c208f) will increase coverage by 0.07%. The diff coverage is 65.51%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   84.93%   85.00%   +0.07%     
==========================================
  Files          37       37              
  Lines        9947     9962      +15     
==========================================
+ Hits         8448     8468      +20     
+ Misses       1499     1494       -5

Impacted Files	Coverage Δ
rift/interface.py	`83.23% <46.66%> (+0.10%)`	:arrow_up:
rift/udp_rx_handler.py	`73.55% <75.00%> (+0.12%)`	:arrow_up:
rift/utils.py	`83.33% <75.00%> (+0.31%)`	:arrow_up:
rift/config.py	`80.11% <100.00%> (+0.11%)`	:arrow_up:
rift/constants.py	`97.05% <100.00%> (+0.04%)`	:arrow_up:
rift/kernel.py	`86.91% <100.00%> (+0.81%)`	:arrow_up:
rift/node.py	`90.95% <100.00%> (+<0.01%)`	:arrow_up:
rift/msg_queues.py	`86.00% <0.00%> (+0.82%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa782a3...9b77b68. Read the comment docs.

brunorijsman commented 2 years ago

Thanks for the catch!

przygienda commented 2 years ago

pushed newest schema updates against you. Status in the description, I have also juniper rift 1.4 on linux available to test if you pull up to libc 2.32

Two kernel tests fail, also on AWS

(env) @.:~/rift-python$ ./env/bin/rift-environ --help ^C (env) @.:~/rift-python$ pytest tests/test_kernel.py

test session starts

platform linux -- Python 3.8.10, pytest-6.1.2, py-1.10.0, pluggy-0.13.1 rootdir: /home/ubuntu/rift-python plugins: profiling-1.7.0, cov-2.10.1 collected 10 items

tests/test_kernel.py .....F.F..

                           [100%]

===================================================================================================== FAILURES

test_put_del_route

def test_put_del_route(): kern = Kernel(simulated_interfaces=False, log=None, log_id="", table_name="5") if not kern.platform_supported: return

Put route with one next-hop (with interface but no address)

   prefix = make_ip_prefix("99.99.99.99/32")
   nhops = [NextHop(False, "lo", None, None)]
   rte = FibRoute(prefix, nhops)

  assert kern.put_route(rte)
E assert False E + where False = <bound method Kernel.put_route of <kernel.Kernel object at 0x7f2f65929df0>>(99.99.99.99/32 -> lo) E + where <bound method Kernel.put_route of <kernel.Kernel object at 0x7f2f65929df0>> = <kernel.Kernel object at 0x7f2f65929df0>.put_route

tests/test_kernel.py:114: AssertionError

test_put_del_route_unreachable

def test_put_del_route_unreachable(): kern = Kernel(simulated_interfaces=False, log=None, log_id="", table_name="main") if not kern.platform_supported: return

Add unreachable prefix in the kernel routing table (no next hops)

   prefix = make_ip_prefix("99.99.99.99/32")
   nhops = []
   rte = FibRoute(prefix, nhops)

  assert kern.put_route(rte)
E assert False E + where False = <bound method Kernel.put_route of <kernel.Kernel object at 0x7f2f65875d30>>(99.99.99.99/32 -> ) E + where <bound method Kernel.put_route of <kernel.Kernel object at 0x7f2f65875d30>> = <kernel.Kernel object at 0x7f2f65875d30>.put_route

tests/test_kernel.py:165: AssertionError

short test summary info

FAILED tests/test_kernel.py::test_put_del_route - assert False FAILED tests/test_kernel.py::test_put_del_route_unreachable - assert False

2 failed, 8 passed in 0.20s

(env) @.***:~/rift-python$

On Thu, Jun 2, 2022 at 8:01 AM Bruno Rijsman @.***> wrote:

Thanks for the catch!

— Reply to this email directly, view it on GitHub https://github.com/brunorijsman/rift-python/pull/113#issuecomment-1144469198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANDIC7ZBCIGOFDDF2KJXZ3VNBE23ANCNFSM5XTB4LFQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

brunorijsman / rift-python

Remove 'spine' from valid strings, add 'leaf-2-leaf' #113