Minor improvements - Githubissues

brunorosilva / plotly-calplot

The easiest and best looking Calendar Heatmap you'll find, made with Plotly.

https://pypi.org/project/plotly-calplot/

108 stars 10 forks source link

Minor improvements #1

Closed daviddavo closed 2 years ago

daviddavo commented 2 years ago

`get_weeknumber_of_date`

The .week function of pandas returns the ISO week date instead of the desired gregorian calendar week number.

The gregorian week date can be obtained with strftime, and now get_weeknumber_of_date is more concise.

`fill_empty_with_zeroes`

This function was giving me some UserWarnings with latest pandas version. It's because you are using a string and pandas recommends using datetime.

[x] I've checked with make pt_example that the desired output is the same

brunorosilva commented 2 years ago

Thanks for the info, all help is welcome