brunyman / MPDB

9 stars 2 forks source link

[BUG][URGENT] Server closing and /mpdb saveAndKick does not save player data #96

Open kpAjun opened 1 year ago

kpAjun commented 1 year ago

Hello, I have found that that if a player remains in the server when it is shutting down, the player's data will not be saved, even if the server executes /mpdb saveAndKick before executing /stop or /restart with MPDB 4.7.1 and Paper 1.18.1-b216, this causes severe item dupe during routine server restarts. To resume the bug:

  1. Leave and rejoin the server with items in inventory (to save the items into MPDB records)
  2. Put everything into a chest and wait for server to stop, no matter /mpdb saveAndKick is executed or not, without leaving
  3. After the server restarts after being stopped, join the server and find everything duped with one copy in inventory and one copy in chest

Multiple tests have been conducted on different servers and the bug appeared in all scenarios. Please fix this, thank you!

kpAjun commented 1 year ago

If you are being very busy and cannot fix bugs in the near future, may I ask for the permission to edit the code of the plugin as the issue is very urgent? Thank you very much.

kpAjun commented 1 year ago

93 Is is possible to check this, too?

Thank you very much! We could not edit the plugin according to the protocols, so things are really problematic for us.