search

brunyuriy / crystalvc

Automatically exported from code.google.com/p/crystalvc
Other
6 stars 5 forks source link

crystal crashes on start up if either hg or git are not installed #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Crystal should:
1. not crash if either is missing (I suppose even if both are missing)
2. exit gracefully if a project requires git (respectively hg) and it is not 
installed.

Original issue reported on code.google.com by yuriy.b...@gmail.com on 12 Sep 2011 at 7:23

GoogleCodeExporter commented 9 years ago 
Ah, I misspoke.  Crystal only crashes if the config file does not specify an 
hgPath or a gitPath.

Original comment by yuriy.b...@gmail.com on 12 Sep 2011 at 7:25

GoogleCodeExporter commented 9 years ago 
Issue has been resolved.  The problem was that Haochen added a check for 
whether git/hg were needed and properly handled the case if it was needed, but 
didn't do anything if it were not needed, which either threw a NPE or entered 
an infinite loop.

Original comment by yuriy.b...@gmail.com on 12 Sep 2011 at 7:48