brunyuriy / crystalvc

Automatically exported from code.google.com/p/crystalvc
Other
6 stars 5 forks source link

shortName cannot handle / \ and space #46

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add a http clone that uses the attached hgignore file

What is the expected output? What do you see instead?

ERROR 2011-10-09 16:15:21,861 (ConflictDaemon.java:116) - Runtime Exception 
caught while getting state for: 
MASTER_HG_http://code.google.com/p/rt-refactor-suggest
Unexpected line in the log file: files:       .hgignore pub/proposal/.hgignore
java.lang.RuntimeException: Unexpected line in the log file: files:       
.hgignore pub/proposal/.hgignore
    at crystal.server.HgLogParser.parseLog(HgLogParser.java:145)
    at crystal.model.RevisionHistory.<init>(RevisionHistory.java:50)
    at crystal.server.HgStateChecker.getRelationship(HgStateChecker.java:295)
    at crystal.client.ConflictDaemon.calculateRelationship(ConflictDaemon.java:83)
    at crystal.client.CalculateProjectTask.doInBackground(CalculateProjectTask.java:113)
    at crystal.client.CalculateProjectTask.doInBackground(CalculateProjectTask.java:23)
    at javax.swing.SwingWorker$1.call(SwingWorker.java:277)
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
    at java.util.concurrent.FutureTask.run(FutureTask.java:138)
    at javax.swing.SwingWorker.run(SwingWorker.java:316)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:619)

What version of the product are you using? On what operating system?

0.2.20110729

Original issue reported on code.google.com by Todd.Sch...@gmail.com on 9 Oct 2011 at 11:41

Attachments:

GoogleCodeExporter commented 9 years ago
I tried setting up crystal with http://code.google.com/p/rt-refactor-suggest 
and it worked fine.  Crystal handles .hgignore files.  

I believe the problem here is a combination of poorly chosen "Short Name" in 
the configuration and Crystal's inability to deal with slashes in that field.  
The short name is intended to be something like "John", or "master", or 
"my_laptop".  A short name with slashes causes problems and it looks like you 
used "http://code.google.com/p/rt-refactor-suggest" as the short name.  

I am going to make Crystal more robust to having spaces and slashes in the 
short name.  Can you please let us know if the documentation was specifically 
confusing in a way that made you put the address in the name field, or if it 
just wasn't clear enough in general.  Thanks,

~ Yuriy

Original comment by yuriy.b...@gmail.com on 10 Oct 2011 at 1:29

GoogleCodeExporter commented 9 years ago
I don't believe I did, from the GUI configuration editor I have the following:

Project Name: rt-refactor-suggest

, and a single repository entry:

Short Name: MASTER
Parent: MASTER
Clone Address: http://code.google.com/p/rt-refactor-suggest

This might be a problem with the GUI configuration editor?

Original comment by Todd.Sch...@gmail.com on 10 Oct 2011 at 1:38

GoogleCodeExporter commented 9 years ago
Fixed this issue in d9bf3c85a520.  Version 1.0.20111015 is a release with the 
fix.  The problem was that Fedora 15 defaults to verbose logs and Crystal could 
not parse such logs.  I could not figure out a way to override the default.  
Crystal now parses verbose logs.  

Original comment by yuriy.b...@gmail.com on 15 Oct 2011 at 8:28

GoogleCodeExporter commented 9 years ago
This issue was closed by revision d9bf3c85a520.

Original comment by yuriy.b...@gmail.com on 15 Oct 2011 at 8:29