I noticed some issues in index.d.ts that I noticed when integrating node-osu with a typescript project
MultiplayerScore is missing types
Some types are Number but should be number
Types assume that parseNumeric is true, because the numeric fields are always number. However, if parseNumeric is false (the default), then those types are wrong.
To resolve 1 and 2 for my use case, I applied the following patch locally:
I noticed some issues in index.d.ts that I noticed when integrating node-osu with a typescript project
Number
but should benumber
parseNumeric
is true, because the numeric fields are alwaysnumber
. However, ifparseNumeric
is false (the default), then those types are wrong.To resolve 1 and 2 for my use case, I applied the following patch locally:
This issue body was partially generated by patch-package.